From 77b79944c546d409e3d96456968130926b93ccc7 Mon Sep 17 00:00:00 2001 From: zhezzz Date: Sat, 24 Jan 2026 18:02:50 +0800 Subject: [PATCH] refactor: remove duplicate getRightItem call in TablesNamesFinder 1. Mark Join.getRightItem() and setRightItem() as @Deprecated since they return the same value as getFromItem(). 2. Remove the duplicate call to join.getRightItem().accept(this, context) in TablesNamesFinder.visit() method, as join.getFromItem() already processes the same FromItem object. --- src/main/java/net/sf/jsqlparser/statement/select/Join.java | 2 ++ src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/net/sf/jsqlparser/statement/select/Join.java b/src/main/java/net/sf/jsqlparser/statement/select/Join.java index 898804de0..f60bdaf46 100644 --- a/src/main/java/net/sf/jsqlparser/statement/select/Join.java +++ b/src/main/java/net/sf/jsqlparser/statement/select/Join.java @@ -277,10 +277,12 @@ public Join withCross(boolean cross) { /** * Returns the right item of the join */ + @Deprecated public FromItem getRightItem() { return fromItem; } + @Deprecated public void setRightItem(FromItem item) { fromItem = item; } diff --git a/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java b/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java index 020332caf..f61c02e70 100644 --- a/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java +++ b/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java @@ -1379,7 +1379,6 @@ private void visitJoins(List joins, S context) { } for (Join join : joins) { join.getFromItem().accept(this, context); - join.getRightItem().accept(this, context); for (Expression expression : join.getOnExpressions()) { expression.accept(this, context); }