Skip to content

Conversation

@lorber98
Copy link
Contributor

  • Centrality in MC GEN and RECO with mcCentrality task: removing FT0C configurable since, currently, there is a CCDB object only for FT0M
  • Remove cut on max radius for compatibility with other O-O analyses
  • Add ConfigurableGroups for better readability

@github-actions github-actions bot added the pwglf label Jan 26, 2026
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

O2 linter results: ❌ 1 errors, ⚠️ 5 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Centrality in MC GEN and RECO with mcCentrality task [PWGLF] Centrality in MC GEN and RECO with mcCentrality task Jan 26, 2026
@lorber98 lorber98 marked this pull request as ready for review January 26, 2026 08:15
Copy link
Collaborator

@romainschotter romainschotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lorber98 ! The PR looks fine but I am not sure you should remove the centrEstimator configurable
If the ccdb object does not exist for the FT0C, I think it would be better to just focus on the FT0M or ask for FT0C MC centrality calibration
However, I thought that there was a MC centrality calibration for the FT0C in OO (at least, I can see that there are 2 objects in ccdb). Maybe @ercolessi has more information
Thank you very much!

@lorber98
Copy link
Contributor Author

lorber98 commented Jan 26, 2026

Hi @lorber98 ! The PR looks fine but I am not sure you should remove the centrEstimator configurable If the ccdb object does not exist for the FT0C, I think it would be better to just focus on the FT0M or ask for FT0C MC centrality calibration However, I thought that there was a MC centrality calibration for the FT0C in OO (at least, I can see that there are 2 objects in ccdb). Maybe @ercolessi has more information Thank you very much!

Hi @romainschotter, thank you for the comment.
I ran some local tests and tried filling the FT0C histogram using the "fillFt0C" = true configurable in the mcCentrality.cxx task, but I encountered some errors, if I did everything correctly. Because of this, I decided to comment out the centrEstimator configurable to keep the code cleaner for now..
However, I will uncomment these lines immediately so that the code is ready to support the FT0C calibration object.
Thanks a lot for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants