serverless-fleets - create subnetpool instead of adding CRNs to default secret, and use the pool in fleet create samples #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt secret, and use the pool in fleet create samples
also minor fixes of cleanup,
and vpc rules protocols ("all" deprecated)
jeremiaswerner
previously approved these changes
Jan 23, 2026
Collaborator
jeremiaswerner
left a comment
jeremiaswerner
left a comment
There was a problem hiding this comment.
LGTM. THANK YOU!
azieseme
dismissed stale reviews from jeremiaswerner and reggeenr
via
6181b49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also minor fixes of cleanup,
and vpc rules protocols ("all" deprecated),
and some unification in sample script echo statements.