Skip to content

Conversation

@vlad-perevezentsev
Copy link
Contributor

This PR suggest implementing dpnp.putmask via a dedicated sycl kernel for a.shape != values.shape; removing the legacy cython implementation of dpnp_putmask and dpnp_algo_indexing.pxi file and updating tests for dpnp.putmask

Currently only C-contiguous input is supported
F-contig and strided support will follow

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev added this to the 0.20.0 release milestone Jan 23, 2026
@vlad-perevezentsev vlad-perevezentsev self-assigned this Jan 23, 2026
@github-actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2735/index.html

@github-actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_64 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 80.765% (-0.3%) from 81.104%
when pulling 13a7adb on impl_putmask
into dc86084 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants