Fix build error handling and refactor Panel.cs

[JasonXuDeveloper]

Summary

Fixes build error handling and improves build system reliability.

What Changed

1. Build Error Handling

• Build now stops when code compilation fails (previously continued to asset build)
• Implemented state machine pattern with EditorApplication.update for non-blocking progress
• Added selective error filtering to ignore known YooAsset catalog bug

2. Code Refactoring

• Extracted BuildManager class (473 lines) from Panel.cs
• Panel.cs reduced from 880 to 467 lines (UI only)
• Removed redundant progress bar (using Unity native progress instead)

3. Build Process Optimization

• Removed duplicate compilation/obfuscation steps (GenerateAll already does this)
• Added explicit GeneratePolymorphicCodes step to ensure it runs
• Simplified from 5 steps to 4 steps: GenerateEncryptionVM → GenerateSecretKey → GenerateAll → GeneratePolymorphicCodes

4. Progress Visualization

• Fixed progress bar not updating during build
• Using EditorUtility.DisplayProgressBar + Unity Progress API
• Log messages show current step

Testing

• ✅ Build stops on actual errors
• ✅ Build continues past known YooAsset catalog error
• ✅ Progress updates visible during build
• ✅ All three build modes work (BuildAll, BuildCodeOnly, BuildAssetsOnly)

[claude]

Code Review

Found 2 issues:

Issue 1: Missing XML Documentation
File: BuildManager.cs line 77
The public property IsBuilding lacks XML documentation per CLAUDE.md requirements.

Issue 2: Missing _progressId Initialization
File: BuildManager.cs lines 142-161
StartBuildAssetsOnly calls UpdateProgress without initializing _progressId (remains -1). Other build methods properly call Progress.Start() first.

Both issues validated and should be fixed before merging.

[claude]

Detailed Issue Descriptions

Issue 1: Missing XML Documentation on IsBuilding Property

Location: BuildManager.cs line 77
Reference: CLAUDE.md requires all public APIs to have XML documentation

Current code is missing documentation:

public bool IsBuilding => _currentStep != BuildStep.None;

Suggested fix - add XML documentation:

/// <summary>
/// Gets a value indicating whether a build operation is currently in progress.
/// </summary>
public bool IsBuilding => _currentStep != BuildStep.None;

Issue 2: Missing _progressId Initialization

Location: BuildManager.cs StartBuildAssetsOnly method (lines 142-161)
Problem: Progress.Report is called with uninitialized _progressId (-1)

The method calls UpdateProgress without first initializing _progressId via Progress.Start(). Both StartBuildAll and StartBuildCodeOnly properly initialize this field before use.

This causes Progress.Report to receive an invalid progress ID, potentially causing silent failures in progress reporting.

Suggested fix - initialize _progressId and add cleanup:

_progressId = Progress.Start("Building Hot Update Assets",
    "Building assets",
    Progress.Options.Managed);

And add a finally block for cleanup like the other methods:

finally
{
    Progress.Remove(_progressId);
    _progressId = -1;
}

[claude]

Code Review - Part 1/3: Bugs

Bug 1: Missing progress ID initialization in StartBuildAssetsOnly

File: BuildManager.cs line 148

Unlike StartBuildAll and StartBuildCodeOnly, the StartBuildAssetsOnly method never calls Progress.Start() to initialize _progressId. When UpdateProgress() is called, it uses Progress.Report(_progressId, ...) with the default value of -1, which is an invalid progress handle.

Compare with:

• StartBuildAll (line 100): _progressId = Progress.Start(...)
• StartBuildCodeOnly (line 124): _progressId = Progress.Start(...)

Fix: Add _progressId = Progress.Start("Building Assets", ...) at the beginning of StartBuildAssetsOnly.

[claude]

Code Review - Part 2/3: Bugs continued

Bug 2: Potential NullReferenceException when Bootstrap is not found

File: BuildManager.cs line 383-384

FindObjectOfType of Bootstrap type returns null if no Bootstrap component exists in the loaded scene. Accessing bootstrap.packageName and bootstrap.targetPlatform without a null check will cause a NullReferenceException.

This can occur if:

• The Bootstrap object was deleted from the startup scene
• The wrong scene path is specified in settings
• The Bootstrap component was removed from the GameObject

Suggested fix: Add a null check after FindObjectOfType and throw a descriptive exception if Bootstrap is not found.

[claude]

Code Review - Part 3/3: CLAUDE.md Compliance

Issue 1: Missing resource cleanup in Panel.cs

When the Panel EditorWindow is closed while a build is in progress, the BuildManager EditorApplication.update callback continues running and attempts to invoke _logCallback, which accesses destroyed UI elements (_logScrollView, _statusLabel).

This violates CLAUDE.md requirements:

• Clean up resources in EditorApplication.quitting
• Proper resource cleanup (ScriptableObjects, event handlers)

See:

JEngine/CLAUDE.md

Lines 111 to 116 in 88f4e2e

	### Editor Scripts
	- Use `[InitializeOnLoad]` for editor initialization
	- Handle Unity domain reloads properly (state resets on recompile)
	- Use `SessionState` or `EditorPrefs` for persistent editor state
	- Clean up resources in `EditorApplication.quitting`

Suggested fix: Add OnDestroy() method to Panel.cs that calls _buildManager?.Cleanup()

Issue 2: Missing XML documentation on IsBuilding property

File: BuildManager.cs line 76

CLAUDE.md requires: Document all public APIs with XML comments

See:

JEngine/CLAUDE.md

Lines 92 to 99 in 88f4e2e

	### Encryption Architecture
	JEngine supports three encryption algorithms:
	- **XOR** (`EncryptionOption.Xor`) - Fast, simple
	- **AES** (`EncryptionOption.Aes`) - Moderate security
	- **ChaCha20** (`EncryptionOption.ChaCha20`) - High security
	Each has implementations for bundles and manifests in `Runtime/Encrypt/`.

Issue 3: Missing XML documentation on BuildManager constructor

File: BuildManager.cs line 78

CLAUDE.md requires: Document all public APIs with XML comments

See:

JEngine/CLAUDE.md

Lines 92 to 99 in 88f4e2e

	### Encryption Architecture
	JEngine supports three encryption algorithms:
	- **XOR** (`EncryptionOption.Xor`) - Fast, simple
	- **AES** (`EncryptionOption.Aes`) - Moderate security
	- **ChaCha20** (`EncryptionOption.ChaCha20`) - High security
	Each has implementations for bundles and manifests in `Runtime/Encrypt/`.