Inconsistent FormField state retrieval due to generic class instantiation #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a suggestion for improvement of the current getAnnotations and getAnnotationsForPage methods.
The
getAnnotationsandgetAnnotationsForPagemethods currently perform a shallow assignment of nested components for widget annotations. Specifically, they instantiate formElement and formField as the base FormElement and FormField classes regardless of the actual form type.On Android this causes the state of Checkbox and Dropdown fields to be unreachable.
On iOS the state is visible through the
valueproperty inside the regular formField object.