-
Notifications
You must be signed in to change notification settings - Fork 41
301updates #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
301updates #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates project dependencies and applies consistent code style changes across Storybook files to match the project's ESLint configuration.
Changes:
- Updated multiple npm dependencies to newer versions (Babel, ESLint, TypeScript, testing libraries, etc.)
- Converted all Storybook story files from double quotes to single quotes and removed semicolons
- Fixed trailing whitespace in webpack.config.mjs
- Added src/stories/** to ESLint ignore list
- Improved code quality by changing
vartoconstin Matrix.stories.js
Reviewed changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependency versions for build tools, linters, and peer dependencies |
| package-lock.json | Updated lockfile to reflect new dependency versions |
| webpack.config.mjs | Removed trailing whitespace from line 18 |
| eslint.config.mjs | Added src/stories/** to ignore list |
| eslint.config.mjs.auth-v2 | New ESLint configuration file (appears to be accidentally committed) |
| src/stories/*.stories.js | Applied consistent code style: single quotes, no semicolons, const over var |
| src/stories/forms/*.stories.js | Applied consistent code style: single quotes, no semicolons |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import typescriptEslint from "@typescript-eslint/eslint-plugin"; | ||
| import typescriptEslintRecommended from "@typescript-eslint/eslint-plugin/configs/recommended"; // Import the recommended config | ||
| import globals from "globals"; | ||
| import tsParser from "@typescript-eslint/parser"; | ||
| import promise from 'eslint-plugin-promise'; | ||
| import promiseRecommended from 'eslint-plugin-promise/recommended'; // Import promise config | ||
| import n from 'eslint-plugin-n'; | ||
| import nRecommendedTs from 'eslint-plugin-n/configs/recommended-typescript'; | ||
| import importPlugin from 'eslint-plugin-import'; // Import import plugin | ||
| import importRecommended from 'eslint-plugin-import/config/recommended'; // Import import config | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: ["**/dist"], | ||
| }, | ||
| { | ||
| plugins: { | ||
| "@typescript-eslint": typescriptEslint, | ||
| promise: promise, | ||
| n: n, | ||
| import: importPlugin, // Add import plugin | ||
| }, | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.browser, | ||
| ...globals.node, | ||
| Atomics: "readonly", | ||
| SharedArrayBuffer: "readonly", | ||
| }, | ||
| parser: tsParser, | ||
| }, | ||
| files: ["src/**/*", "test/**/*"], | ||
| }, | ||
| // spread the configuration files into the final config | ||
| typescriptEslintRecommended, | ||
| promiseRecommended, | ||
| nRecommendedTs, | ||
| importRecommended, // Add import config | ||
| { | ||
| rules: { | ||
| "no-unused-vars": ["warn", { | ||
| argsIgnorePattern: "^_", | ||
| varsIgnorePattern: "^_", | ||
| }], | ||
| "@typescript-eslint/no-unused-vars": ["warn", { | ||
| argsIgnorePattern: "^_", | ||
| varsIgnorePattern: "^_", | ||
| }], | ||
| "promise/param-names": "error", | ||
| "n/no-callback-literal": "error", | ||
| // Remove rules added by the extends and not needed | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/explicit-module-boundary-types": "off", | ||
| "no-var": "warn", | ||
| "n/no-unsupported-features/es-syntax": "off", | ||
| // import rules | ||
| 'import/no-unresolved': 'off', // Because of the types conflict | ||
| 'import/named': 'warn', | ||
| 'import/default': 'warn', | ||
| 'import/namespace': 'warn', | ||
| 'import/no-absolute-path': 'warn', | ||
| 'import/no-dynamic-require': 'warn', | ||
| 'import/no-webpack-loader-syntax': 'warn', | ||
| 'import/no-self-import': 'warn', | ||
| 'import/no-useless-path-segments': 'warn', | ||
| 'import/export': 'warn', | ||
| 'import/no-named-as-default': 'warn', | ||
| 'import/no-named-as-default-member': 'warn', | ||
| 'import/no-deprecated': 'warn', | ||
| 'import/no-extraneous-dependencies': 'warn', | ||
| 'import/no-mutable-exports': 'warn' | ||
| }, | ||
| } | ||
| ]; |
Copilot
AI
Jan 24, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire file appears to be accidentally committed. The filename suffix ".auth-v2" suggests this is a backup, alternative configuration, or work-in-progress file that should not be part of the main codebase. There are no references to this file elsewhere in the project, and it duplicates functionality already present in the main eslint.config.mjs file. Consider removing this file unless there's a specific reason for its inclusion that should be documented.
| import typescriptEslint from "@typescript-eslint/eslint-plugin"; | |
| import typescriptEslintRecommended from "@typescript-eslint/eslint-plugin/configs/recommended"; // Import the recommended config | |
| import globals from "globals"; | |
| import tsParser from "@typescript-eslint/parser"; | |
| import promise from 'eslint-plugin-promise'; | |
| import promiseRecommended from 'eslint-plugin-promise/recommended'; // Import promise config | |
| import n from 'eslint-plugin-n'; | |
| import nRecommendedTs from 'eslint-plugin-n/configs/recommended-typescript'; | |
| import importPlugin from 'eslint-plugin-import'; // Import import plugin | |
| import importRecommended from 'eslint-plugin-import/config/recommended'; // Import import config | |
| export default [ | |
| { | |
| ignores: ["**/dist"], | |
| }, | |
| { | |
| plugins: { | |
| "@typescript-eslint": typescriptEslint, | |
| promise: promise, | |
| n: n, | |
| import: importPlugin, // Add import plugin | |
| }, | |
| languageOptions: { | |
| globals: { | |
| ...globals.browser, | |
| ...globals.node, | |
| Atomics: "readonly", | |
| SharedArrayBuffer: "readonly", | |
| }, | |
| parser: tsParser, | |
| }, | |
| files: ["src/**/*", "test/**/*"], | |
| }, | |
| // spread the configuration files into the final config | |
| typescriptEslintRecommended, | |
| promiseRecommended, | |
| nRecommendedTs, | |
| importRecommended, // Add import config | |
| { | |
| rules: { | |
| "no-unused-vars": ["warn", { | |
| argsIgnorePattern: "^_", | |
| varsIgnorePattern: "^_", | |
| }], | |
| "@typescript-eslint/no-unused-vars": ["warn", { | |
| argsIgnorePattern: "^_", | |
| varsIgnorePattern: "^_", | |
| }], | |
| "promise/param-names": "error", | |
| "n/no-callback-literal": "error", | |
| // Remove rules added by the extends and not needed | |
| "@typescript-eslint/no-explicit-any": "off", | |
| "@typescript-eslint/explicit-module-boundary-types": "off", | |
| "no-var": "warn", | |
| "n/no-unsupported-features/es-syntax": "off", | |
| // import rules | |
| 'import/no-unresolved': 'off', // Because of the types conflict | |
| 'import/named': 'warn', | |
| 'import/default': 'warn', | |
| 'import/namespace': 'warn', | |
| 'import/no-absolute-path': 'warn', | |
| 'import/no-dynamic-require': 'warn', | |
| 'import/no-webpack-loader-syntax': 'warn', | |
| 'import/no-self-import': 'warn', | |
| 'import/no-useless-path-segments': 'warn', | |
| 'import/export': 'warn', | |
| 'import/no-named-as-default': 'warn', | |
| 'import/no-named-as-default-member': 'warn', | |
| 'import/no-deprecated': 'warn', | |
| 'import/no-extraneous-dependencies': 'warn', | |
| 'import/no-mutable-exports': 'warn' | |
| }, | |
| } | |
| ]; | |
| // This file is intentionally kept as a thin alias to the main ESLint config. | |
| // Some tooling and legacy scripts may reference `eslint.config.mjs.auth-v2` | |
| // directly, so we re-export the primary configuration instead of duplicating it. | |
| // All actual ESLint settings should be maintained in `eslint.config.mjs`. | |
| import mainConfig from "./eslint.config.mjs"; | |
| export default mainConfig; |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.