Skip to content

Conversation

@bourgeoa
Copy link
Contributor

rdflib@2.3.5 solid-logic@4.0.2

Copilot AI review requested due to automatic review settings January 24, 2026 18:05
@bourgeoa bourgeoa merged commit 133fc2e into main Jan 24, 2026
6 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Solid UI’s published version and aligns its peer dependency requirements for rdflib and solid-logic with newer patch releases.

Changes:

  • Bump package version to 3.0.3.
  • Update peerDependencies to rdflib@^2.3.5 and solid-logic@^4.0.2.
  • Remove rdflib and solid-logic from devDependencies and regenerate package-lock.json accordingly.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

File Description
package.json Updates library version and adjusts dependency declarations for rdflib/solid-logic.
package-lock.json Lockfile updates reflecting the new peer dependency versions and dependency graph metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 116 to 122
"jsdom": "^27.4.0",
"neostandard": "^0.12.2",
"nock": "^15.0.0",
"rdflib": "^2.3.5",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-is": "^17.0.2",
"solid-logic": "^4.0.2",
"storybook": "8.6.15",
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rdflib and solid-logic are imported throughout src/ and test/ (e.g., many files import from these packages). Removing them from devDependencies can make npm test/npm run build fail in a fresh checkout unless the package manager installs root peerDependencies into the workspace. Consider adding them back to devDependencies (keeping them in peerDependencies for consumers) so contributors/CI can reliably install and run builds/tests.

Copilot uses AI. Check for mistakes.
Comment on lines +77 to +78
"rdflib": "^2.3.5",
"solid-logic": "^4.0.2"
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peer dependency ranges were tightened (rdflib from ^2.3.0 to ^2.3.5, solid-logic from ^4.0.1 to ^4.0.2). This can be a breaking change for consumers pinned to the earlier patch versions. If there isn't a hard requirement on these minimum patch versions, consider keeping the previous ranges or using an explicit compatible range that still allows earlier patches.

Suggested change
"rdflib": "^2.3.5",
"solid-logic": "^4.0.2"
"rdflib": "^2.3.0",
"solid-logic": "^4.0.1"

Copilot uses AI. Check for mistakes.
{
"name": "solid-ui",
"version": "3.0.2",
"version": "3.0.3",
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version is bumped as a patch release (3.0.23.0.3), but tightening peer dependency minimums can be breaking for downstream apps. If this peer range narrowing is intentional, consider whether the package version should be a minor/major bump per semver (or document the breaking requirement in release notes).

Suggested change
"version": "3.0.3",
"version": "3.1.0",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants