Skip to content

Conversation

@TheBobBobs
Copy link
Contributor

Summary

If an ORList has only invalid tags return False.

The default query is an empty ORList so return True if the ORList contained no elements before seperating tags.

fixes #1287

Tasks Completed

  • Platforms Tested:
    • Linux x86
  • Tested For:
    • Basic functionality

@TrigamDev TrigamDev added Status: Review Needed A review of this is needed TagStudio: Search The TagStudio search engine Type: Fix A fix for a bug, typo, or other issue Priority: Low Doesn't require immediate attention labels Jan 21, 2026
@Computerdores
Copy link
Collaborator

Computerdores commented Jan 21, 2026

While this might1 fix the specific symptom reported in #1287 this doesn't address the root cause of this issue, which is likely that __separate_tags incorrectly handles list of only incorrect tag names. And since __separate_tags is used elsewhere too from what I remember, it would be better to fix that method.

Footnotes

  1. I am not doubting that it does, I just didn't test it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed TagStudio: Search The TagStudio search engine Type: Fix A fix for a bug, typo, or other issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Search OR returns everything when no tag exists

3 participants