Expose onlineDetector and add check online status before executing transactions #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9a5bb56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Toba-bonjour
force-pushed
the
toba/skip-transaction-retry-when-offline
branch
from
1d51bbf to
0a292f5
Compare
…tion when offline - Add onlineDetector config option to allow custom online detection - Change onlineDetector type from DefaultOnlineDetector to OnlineDetector interface - Add isOnline() and dispose() methods to OnlineDetector interface - Check online status before executing transactions in TransactionExecutor - Clear scheduler before reloading filtered transactions to ensure consistency - Pass onlineDetector to TransactionExecutor for status checks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Toba-bonjour
force-pushed
the
toba/skip-transaction-retry-when-offline
branch
from
0a292f5 to
d68bebe
Compare
Toba-bonjour
changed the title
Resolve conflicts: - OfflineExecutor.ts: Use WebOnlineDetector as default (renamed from DefaultOnlineDetector) - types.ts: Keep isOnline() method in OnlineDetector interface, add doc comment - offline-e2e.test.ts: Include both custom OnlineDetector tests and optimistic state restoration tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Match production WebOnlineDetector behavior by skipping notification when offline. This prevents tests from passing with behavior that would fail in production. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
From Discord https://discord.com/channels/719702312431386674/1451931709296869426/1451931709296869426
Raw changes
isOnline(): booleantoOnlineDetectorinterfaceonlineDetector?: OnlineDetector | nulltoOfflineConfigTransactionExecutor.runExecution()to check online status before processingProblem
Currently,
TransactionExecutorattempts to execute transactions even when the user is offline, leading to:Solution
This PR introduces configurable online detection to prevent transaction execution when offline:
OnlineDetectorinterface withisOnline()methodOfflineConfig:undefined(default): usesDefaultOnlineDetector✅ Checklist
pnpm test:pr.🚀 Release Impact