Skip to content

fix: DynamicVoiceChat throwing an exception when event occurs in non-voice channel #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tj-wazei merged 1 commit into from
Jan 24, 2026
Merged

fix: DynamicVoiceChat throwing an exception when event occurs in non-voice channel #1391

tj-wazei merged 1 commit into from
Jan 24, 2026

Conversation

@tj-wazei
Copy link
Contributor

@tj-wazei tj-wazei commented Jan 24, 2026

Description

An IllegalStateException was being thrown when an event happened on a non-voice channel.

In this PR:

  • Removed unnecessary annotations (Intellij linting)
  • Split the join/leave logic into their own methods for clarity
  • Removed the "auto create" of the archive category, the logic here did not create the category properly with permissions, it's best to just error log here.
  • Nit: inline sendWarningEmbed

@tj-wazei tj-wazei marked this pull request as ready for review January 24, 2026 15:35
@tj-wazei tj-wazei requested a review from a team as a code owner January 24, 2026 15:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 24, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

christolis
christolis approved these changes Jan 24, 2026
View reviewed changes
Copy link
Member

@christolis christolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tj-wazei tj-wazei merged commit a62f773 into develop Jan 24, 2026
11 checks passed
@tj-wazei tj-wazei deleted the fix-dynamic-vc branch January 24, 2026 15:57
@tj-wazei tj-wazei mentioned this pull request Jan 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christolis christolis christolis approved these changes

@marko-radosavljevic marko-radosavljevic marko-radosavljevic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tj-wazei @christolis @marko-radosavljevic @surajkumar