Manual rebasing setting and rebase to remote base action #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase to Remote Base action
Member
|
Hi @3rdit , thanks for the PR! I had a quick look at the PR, and it looks great. However, I prefer that during manual rebasing, a base address can be provided by the user. An important motivation for this PR is that when the auto-detected base address is wrong, the user would still be able to provide the correct value after inspecting the target. Bonus point if we provide a default value that is likely the one the debugger thinks is the right base, but that is totally optional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to disable automatic rebasing when debugging and allow (optional) manual rebasing instead.
A new setting
debugger.autoRebase(default: true) controls whether the debugger automatically rebases the input binary view when the module is loaded. The user can manually rebase via "Rebase to Remote Base" in the debugger menu or context menu.This PR will close #821, will close #214, and will close Vector35/binaryninja-api#4799 (as it is the last mentioned unclosed issue)