Fix import checking when table's runtime size changes #8222
+40
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenfontanella
force-pushed
the
table-import
branch
5 times, most recently
from
d465928 to
f30f8c6
Compare
stevenfontanella
added a commit
that referenced
this pull request
Jan 22, 2026
Part of #8180. We currently replicate the existing behavior. In the future, we can also change ctor-eval to really simulate tables, and only use the EvallingRuntimeTable in the case of table imports. Removes existing pointer chasing logic that we repeat for each table operation (e.g. tableLoad, tableStore). Allows us to fix spec tests where a table import becomes valid by resizing it in #8222.
stevenfontanella
force-pushed
the
table-grow-spec-test
branch
2 times, most recently
from
0e6a253 to
cad1017
Compare
stevenfontanella
force-pushed
the
table-grow-spec-test
branch
from
cad1017 to
1156ba6
Compare
kripken
reviewed
Jan 23, 2026
| size() >= other.initial && tableMeta_.max <= other.max; | ||
| } | ||
|
|
||
| const Table* tableMeta() const { return &tableMeta_; } |
Member
There was a problem hiding this comment.
What does "meta" mean here? Could this be getTable() perhaps?
Member
Author
There was a problem hiding this comment.
I meant it like 'metadata', I didn't want to name this table since this class is also a table. I think the Table struct represents something more like a table definition than a table itself, maybe I can rename this to tableDefinition?
Member
There was a problem hiding this comment.
I see, yeah, maybe getDefinition() then? This is indeed the definition of the runtime table.
Member
Author
There was a problem hiding this comment.
Sounds good, I put it in the next PR if that sounds good #8230
tlively
approved these changes
Jan 23, 2026
stevenfontanella
added a commit
that referenced
this pull request
Jan 24, 2026
Suggested in [#8222#discussion_r2721815229](#8222 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableUtils::IsSubType is removed because it never makes sense to check for subtyping between two (static)
Tabledefinitions, since the runtime size must be taken into account.Fixes the
table_grow.wastspec test.Also make tableMeta() non-virtual in RuntimeTable since the base class has the field and it never makes sense to override it.