Skip to content

Ignore emcc-build in flake8 #8225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevenfontanella merged 1 commit into from
Jan 24, 2026
Merged

Ignore emcc-build in flake8 #8225

stevenfontanella merged 1 commit into from
Jan 24, 2026
+1 −1

Conversation

@stevenfontanella
Copy link
Member

@stevenfontanella stevenfontanella commented Jan 22, 2026

The directory is created by ./scripts/emcc-tests.sh and contains python files that don't pass the formatting check

./emcc-build/test/lit/lit.site.cfg.py:3:1: F821 undefined name 'config'
./emcc-build/test/lit/lit.site.cfg.py:4:1: F821 undefined name 'config'
./emcc-build/test/lit/lit.site.cfg.py:6:1: F821 undefined name 'lit_config'
./emcc-build/test/lit/lit.site.cfg.py:7:5: F821 undefined name 'config'
./emcc-build/test/lit/lit.site.cfg.py:7:26: F821 undefined name 'config'

@stevenfontanella stevenfontanella marked this pull request as ready for review January 23, 2026 21:59
@stevenfontanella stevenfontanella merged commit 959b357 into main Jan 24, 2026
17 checks passed
@stevenfontanella stevenfontanella deleted the flake8 branch January 24, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlively tlively tlively approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevenfontanella @tlively