[NFC] Collect function names first in PossibleContents' External phase #8229
+16
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The External phase considers all externally-visible things and marks them
as such. That includes functions in a public table. The old code ran on each
item and processed it, which turns out to be very slow on Dart: Dart can
have massive tables with many repeated elements, so it is much faster to
first collect the function names in a set, then process those.
This makes
--gufaon this large Dart testcase 7.7x faster - not 7.7 percent,but times: from 393 seconds to 51. (This is the same situation as in #8048,
again the huge table is not something we have handled well.)