Fix clang20 jsc build #1606
Merged
Fix clang20 jsc build #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmichaud
force-pushed
the
eng/32-bit-build-fix-clang-20
branch
from
6141bbc to
87df002
Compare
Author
|
Upstream: WebKit/WebKit#57177 |
https://bugs.webkit.org/show_bug.cgi?id=306182 Reviewed by Yusuke Suzuki. See WebPlatformForEmbedded#1600. We fix this build error: ``` <inline asm>:320:49: error: Relocation Not In Range 320 | movw r4, #:lower16:.Lllint_op_tail_call_varargs - .Lllint_relativePCBase | ^ <inline asm>:321:49: error: Relocation Not In Range 321 | movt r4, #:upper16:.Lllint_op_tail_call_varargs - .Lllint_relativePCBase ... by emiting a worse sequence, a jump + data + a pc-relative load. This is only emitted at startup, so the perf impact should be minimal. * Source/JavaScriptCore/offlineasm/arm.rb: Canonical link: https://commits.webkit.org/306181@main
justinmichaud
force-pushed
the
eng/32-bit-build-fix-clang-20
branch
from
87df002 to
8dd9c72
Compare
magomez
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.webkit.org/show_bug.cgi?id=305773
See #1600.
We fix this build error: