Skip to content

Conversation

@huzaifaalmesbah
Copy link
Member

This PR updates variable names in wp-admin includes to strictly adhere to WordPress Coding Standards (lowercase with underscores, no unnecessary abbreviations). These changes focus on local variables to avoid backward compatibility issues.

Trac ticket: https://core.trac.wordpress.org/ticket/64226

Changes

  • src/wp-admin/includes/post.php: Renamed $id3data to $id3_data in edit_post().
  • src/wp-admin/includes/media.php: Renamed $ext to $extension and $ext_type to $extension_type in media_handle_upload() and media_send_to_editor().
  • src/wp-admin/includes/image-edit.php: Renamed $ext to $extension in wp_image_editor().

Testing Instructions

  1. Media Upload: Upload image, audio, and video files. Ensure uploads complete successfully and correct icons/metadata are displayed.
  2. Image Editing: Go to Media Library, select an image, click "Edit Image", perform a crop or rotation, and save. Confirm the edit is applied successfully.
  3. General Admin: Edit a post and verify the page loads and saves correctly without any PHP notices or errors.

Rename $id3data, $ext, and $ext_type variables to $id3_data, $extension, and $extension_type respectively, to comply with WordPress Coding Standards.

See #64226.
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant