-
Notifications
You must be signed in to change notification settings - Fork 263
Upgrade to Android Gradle Plugin 9.0.0 #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
liutikas
commented
Jan 22, 2026
- Upgrade to Gradle 9.3.0
- Upgrade to Hilt 2.59
- Upgrade to Baseline Profile plugin 1.5.0-alpha01
- Upgrade to Google OSS plugin 0.10.10
- Upgrade to Kotlin 2.3.0
- Upgrade to KSP 2.3.4
- Adapt to built-in kotlin in AGP
- Add a missing bom entry in :watchface
- Ensure that we dont use transtive deps in :wear APK copying
Summary of ChangesHello @liutikas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive upgrade of the project's build infrastructure, primarily migrating to Android Gradle Plugin 9.0.0 and Gradle 9.3.0. This foundational update involves bumping numerous associated dependencies, including Kotlin, Hilt, and various plugins, and adapting the build configuration to align with new AGP features like built-in Kotlin support. Additionally, it refines specific module configurations related to asset handling and dependency transitivity, ensuring the project remains robust and compatible with the latest Android development toolchain. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades several key dependencies, including Android Gradle Plugin to 9.0.0, Gradle to 9.3.0, and Kotlin to 2.3.0. The changes correctly adapt the build scripts to these new versions, such as removing the explicit application of the Kotlin Android plugin, which is now bundled with AGP. The Gradle wrapper scripts (gradlew and gradlew.bat) have also been updated to the new standard versions. My review identified a couple of critical issues in the updated gradlew script related to incorrect quoting of shell variables, which could cause script failures on certain platforms. I've provided suggestions to fix these. The rest of the changes look good and are consistent with the goals of the pull request.
8e7579c to
878f52f
Compare
| tasks.named("pre${capsVariant}Build").configure { | ||
| dependsOn(tokenTask) | ||
| } | ||
| apkFileCollection.from(configurations.getByName("watchfaceApk$capsVariant")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garanj can you review this change since its watchface related?
|
@dturner are you hearing of any issues with Nav3 and AGP 9? |
|
@riggaroo Just in case anyone else runs into the issue, the fix was to update to the latest version of |
Upgrade lifecycleViewmodelNavigation3 to 2.10.0
- Upgrade to Gradle 9.3.0 - Upgrade to Hilt 2.59 - Upgrade to Baseline Profile plugin 1.5.0-alpha01 - Upgrade to Google OSS plugin 0.10.10 - Upgrade to Kotlin 2.3.0 - Upgrade to KSP 2.3.4 - Adapt to built-in kotlin in AGP - Add a missing bom entry in :watchface - Ensure that we dont use transtive deps in :wear APK copying - Disable built-in kotlin in :wear:watchface - Rewrite :wear tasks that add generated APK and XML resources - Add kotlin.test dependency to :feature:creation, see https://issuetracker.google.com/issues/478268626