-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Python] Support large pipeline options via file (Fixes #37370) #37379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Mathdee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust solution for handling large pipeline options in the Python SDK, which previously led to an 'argument list too long' error due to operating system limitations on environment variable size. By transitioning from direct environment variable passing to a file-based approach, where options are written to a temporary file and its path is referenced, the system can now accommodate extensive configurations without encountering runtime failures. This enhancement ensures greater stability and consistency across SDKs. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
All linting and integration checks are passing. Ready for review |
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@shunping can you take a pass at this since you have more context? |
Issue:
As described in #37370, running pipelines with large options on Dataflow causes
fork/exec /usr/local/bin/python: argument list too long.This occurs because the bootloader passes the complete JSON config via
PIPELINE_OPTIONSenvironment variable --> exceeds the OSARG_MAXlimit.The Fix:
This change uses an identical pattern from the Go SDK (Issue #27839, Commit e31e885) to Python.
pipeline_options.json) and sets thePIPELINE_OPTIONS_FILEenvironment variable.PIPELINE_OPTIONS_FILEand loads the configs from the disk if present.Outcome:
Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.Update
CHANGES.mdwith noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.