-
Notifications
You must be signed in to change notification settings - Fork 210
Add retry button in ViewLogs modal #2805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Console (appwrite/console)Project ID: Tip Trigger functions via HTTP, SDKs, events, webhooks, or scheduled cron jobs |
WalkthroughAdds an optional Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/lib/components/domains/viewLogsModal.svelte`:
- Around line 70-75: The long <Modal> opening tag exceeds the 100-char Prettier
limit; reformat the <Modal title="Certificate logs" size="m" bind:show
bind:error onSubmit={retryDomain} hideFooter={selectedProxyRule.status !==
ProxyRuleStatus.Unverified}> tag by breaking its attributes onto multiple lines
(one attribute per line), align indentation with surrounding markup, and place
the closing ">" on its own line so the tag and its props fit within the
line-length rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/lib/components/domains/viewLogsModal.svelte`:
- Around line 55-58: The catch block currently assigns error = e.message which
can crash if e is not an Error; update the catch to defensively extract the
message from the caught value (the catch param e) and assign a safe string to
the variable error (e.g. use e instanceof Error ? e.message : (typeof e ===
'object' && e && 'message' in e ? String((e as any).message) : String(e))) so
the component variable error always receives a string; locate the catch in
viewLogsModal.svelte and replace the direct e.message access with this guarded
extraction.
🧹 Nitpick comments (1)
src/lib/components/domains/viewLogsModal.svelte (1)
26-26: Type theerrorstate explicitly to avoid null-only inference.
$state(null)can infernulland reject string assignments under stricter TS configs. Consider a union type to keep type safety.♻️ Suggested tweak
- let error = $state(null); + let error = $state<string | null>(null);

Closes SER-1069
Summary by CodeRabbit
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.