Skip to content

Conversation

@rpardini
Copy link
Member

@rpardini rpardini commented Jan 18, 2026

Summary by CodeRabbit

Release Notes

  • Improvements
    • Device tree compilation now includes runtime version compatibility checks to ensure proper processing
    • Normalization is conditionally applied based on tool version, optimizing the compilation process
    • Enhanced compilation diagnostics and logging for better visibility into the build process

✏️ Tip: You can customize this high-level summary in your review settings.

…zed dts

- 1.7.2 does not resolve phandles in dts<->dts mode, which is much more useful
- I learned about this from https://lore.kernel.org/u-boot/20251219024102.145220-1-marek.vasut+renesas@mailbox.org/
- also add `-s` (sorted) flag, which further enhances comparability
- hint: Debian Trixie has 1.7.2; Ubuntu Noble only 1.7.0
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

📝 Walkthrough

Walkthrough

The change adds runtime dtc (Device Tree Compiler) version detection to a kernel compilation script. It conditionally applies DTB normalization and phandle filtering based on whether dtc version is 1.7.2 or higher, replacing a previous phandle/connection pattern with a simpler grep-based approach and adding informational logging throughout the decision flow.

Changes

Cohort / File(s) Summary
DTB Normalization Logic
lib/functions/compilation/kernel.sh
Adds dtc version parsing and conditional normalization flow; replaces complex phandle/connection/hex filter with simple phandle grep; introduces version check gate (< 1.7.2 skips normalization); adds informational alert and summary logging; implements early return pattern when conditions unmet

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 A version check hops through the night,
Dtc 1.7.2—just right!
Phandles filtered with a swift grep,
Early returns keep the kernel in step,
Normalization blooms when conditions align. 🌿✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding a runtime dtc version check before normalizing DTB/DTS files, with version 1.7.2 as the threshold.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Jan 18, 2026
@rpardini rpardini marked this pull request as ready for review January 18, 2026 20:53
@rpardini rpardini requested a review from a team as a code owner January 18, 2026 20:53
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants