fix: add security attributes to external links in accept payments guide #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….mdx to improve documentation coverage
… in accept-payments.mdx
Collaborator
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why? I added rel="noopener noreferrer" to external links (Circle Faucet and Sepolia BaseScan) in
docs/base-account/guides/accept-payments.mdx
that open in a new tab (target="_blank"). This prevents potential reverse tabnabbing vulnerabilities.
Notes to reviewers Standard security improvement for external documentation links.
How has it been tested? Verified valid markdown syntax and confirmed the links render correctly.