Skip to content

Conversation

@dietmarkuehl
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 25, 2026 00:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the library’s stoppable-token infrastructure so std::stop_token can satisfy the stoppable_token concept (Issue 200).

Changes:

  • Introduces detail::stoppable_token_traits to abstract how a token provides its stop-callback type (with a specialization for std::stop_token).
  • Refactors stoppable_token and stop_callback_for_t to use the new traits instead of directly requiring Token::callback_type.
  • Adds a regression test for std::stop_token and wires it into the test CMake list.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/beman/execution/issue-200.test.cpp Adds compile-time assertion that std::stop_token models stoppable_token.
tests/beman/execution/CMakeLists.txt Registers the new Issue 200 test target.
include/beman/execution/detail/stoppable_token.hpp Updates stoppable_token concept to validate callback support via stoppable_token_traits.
include/beman/execution/detail/stop_token_traits.hpp New traits header providing a generic mapping + std::stop_token specialization.
include/beman/execution/detail/stop_callback_for_t.hpp Updates stop_callback_for_t alias to use stoppable_token_traits.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

coveralls commented Jan 25, 2026

Coverage Status

coverage: 92.63%. remained the same
when pulling 18c3e57 on issue-200
into a098f90 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants