Add Subprocess Job Execution Support #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josbeir
force-pushed
the
sub-process
branch
2 times, most recently
from
c80bb73 to
849f868
Compare
ADmad
reviewed
Dec 18, 2025
markstory
reviewed
Jan 26, 2026
| } | ||
|
|
||
| try { | ||
| $data = json_decode($input, true, 512, JSON_THROW_ON_ERROR); |
Member
There was a problem hiding this comment.
What's 512? Can we use the union of the flag constants?
Comment on lines
+127
to
+134
| while (!feof(STDIN)) { | ||
| $chunk = fread(STDIN, 8192); | ||
| if ($chunk === false) { | ||
| break; | ||
| } | ||
|
|
||
| $input .= $chunk; | ||
| } |
Member
There was a problem hiding this comment.
Could we read input from $io Using stdin will make this harder to test/mock/change in the future.
|
|
||
| /** | ||
| * Configure logging to use STDERR to prevent job logs from contaminating STDOUT. | ||
| * Reconfigures all CakePHP loggers to write to STDERR with no additional formatting. |
Member
There was a problem hiding this comment.
Why? Won't that break logging outputs to files/syslog log drain services?
Comment on lines
+196
to
+199
| return [ | ||
| 'success' => false, | ||
| 'error' => sprintf('Subprocess output exceeded maximum size of %d bytes', $maxOutputSize), | ||
| ]; |
|
|
||
| $exitCode = proc_close($process); | ||
|
|
||
| if ($exitCode !== 0 && empty($output)) { |
Member
There was a problem hiding this comment.
Could the output ever be '0'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running queue jobs in isolated subprocesses. That allows code changes to take effect immediately without restarting long‑running workers, speeding up iterative development and reducing workflow friction. Subprocess execution also contains job failures to the child process, improving stability of the main worker and making debugging safer and more predictable.
Key Features
Subprocess Execution: New
SubprocessProcessorwraps the standard processor to execute jobs in isolated PHP processes viaproc_open(), communicating job data and results over stdin using JSON.CLI Command:
SubprocessJobRunnerCommandhandles single job execution within the subprocess, accepting job data via STDIN and returning results via STDOUT.Worker Integration: Added
--subprocessflag toWorkerCommandto enable subprocess mode. Also configurable viaQueue.subprocessconfig key.Configuration
Note about logging to stdout
As messaging between worker and sub command is using stdout with json i decided to redirect all other stdout logging to stderr. This seemed like a fine balance as subprocesses would only be used locally. And even if they where to be used in production for any reason (memory, crash resilience?) then a dedicated log engine could be used instead.