Skip to content

Conversation

@clue
Copy link
Owner

@clue clue commented Jan 25, 2026

@clue clue added this to the v1.6.0 milestone Jan 25, 2026
@clue clue requested a review from Copilot January 25, 2026 20:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds PHP 8.5 to the CI test matrix and updates dependencies to versions that support PHP 8.5. It also modifies reflection API usage in tests to conditionally call setAccessible() only on PHP versions prior to 8.1, where it's required.

Changes:

  • Adds PHP 8.5 to the GitHub Actions CI workflow test matrix
  • Updates react/event-loop, react/promise, react/socket, and rize/uri-template dependency versions
  • Adds PHP version checks in ClientTest.php to conditionally call setAccessible() only on PHP < 8.1

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/ci.yml Adds PHP 8.5 to the test matrix to ensure compatibility with the latest PHP version
composer.json Updates dependency versions to support PHP 8.5 (event-loop ^1.6, promise ^3.3, socket ^1.17, uri-template ^0.4.1)
tests/ClientTest.php Adds conditional checks to only call setAccessible() on PHP < 8.1, where it's required for accessing private properties via reflection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@clue clue merged commit 6915d97 into clue:1.x Jan 25, 2026
21 checks passed
@clue clue deleted the php8.5 branch January 25, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant