feat(style) - textShadow CSS syntax
#55289
Open
+692
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds support for textShadow CSS syntax.
Changelog:
[GENERAL] [ADDED] -
textShadowCSS syntaxTest Plan:
Added fantom test for parsing syntax and an example in RNTester.
Known issues
blurRadiusproperty is required on Android due to limitation of setShadowLayer platform API. Workaround for 0 blur radius would be to pass a value like 0.01.textShadow. Supporting multiple text shadows would require manual drawing (platform API limitation) which could increase the performance cost.