Skip to content

Conversation

@ljharb
Copy link

@ljharb ljharb commented Jan 23, 2026

Updates

  • Affected products

Comments
Versions 0.0.0 - 0.0.4 are NOT vulnerable - they use Node.js's built-in url.parse() which handles backslashes correctly. The vulnerability was introduced in 0.1.0 when custom URL parsing was added.

Copilot AI review requested due to automatic review settings January 23, 2026 01:04
@github-actions github-actions bot changed the base branch from main to ljharb/advisory-improvement-6697 January 23, 2026 01:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a security advisory for the url-parse npm package to correct the affected version range. The vulnerability (CVE-2018-3774) was incorrectly listed as affecting all versions from 0 onwards, but actually only affects versions starting from 0.1.0, as versions 0.0.0-0.0.4 used Node.js's built-in url.parse() which handles backslashes correctly.

Changes:

  • Updated the "introduced" version from "0" to "0.1.0" to accurately reflect when the vulnerability was introduced
  • Updated the "modified" timestamp to reflect the advisory change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shelbyc
Copy link
Contributor

shelbyc commented Jan 23, 2026

Hi @ljharb, unshiftio/url-parse@0.0.4...0.1.0 agrees with you that custom URL parsing was added in 0.1.0.

@advisory-database advisory-database bot merged commit 1c01dcc into ljharb/advisory-improvement-6697 Jan 23, 2026
9 of 10 checks passed
@advisory-database
Copy link
Contributor

Hi @ljharb! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@advisory-database advisory-database bot deleted the ljharb-GHSA-pv4c-p2j5-38j4 branch January 23, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants