-
Notifications
You must be signed in to change notification settings - Fork 451
Enabling aot on samples with aot support published #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Removes the explicit PublishAot=false override from the .NET cookbook “file-based app” recipes so they no longer opt out of AOT publishing.
Changes:
- Removed
#:property PublishAot=falsefrom each cookbook recipe.csfile so AOT can be enabled when publishing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| cookbook/dotnet/recipe/pr-visualization.cs | Removes the directive that forced PublishAot=false. |
| cookbook/dotnet/recipe/persisting-sessions.cs | Removes the directive that forced PublishAot=false. |
| cookbook/dotnet/recipe/multiple-sessions.cs | Removes the directive that forced PublishAot=false. |
| cookbook/dotnet/recipe/managing-local-files.cs | Removes the directive that forced PublishAot=false. |
| cookbook/dotnet/recipe/error-handling.cs | Removes the directive that forced PublishAot=false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,5 +1,4 @@ | |||
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |||
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |
| // Note: AOT is enabled by default for this recipe. | |
| // To disable AOT (for example, during local development), add: | |
| // #:property PublishAot=false |
| @@ -1,5 +1,4 @@ | |||
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |||
| #:property PublishAot=false | |||
|
|
|||
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.
| // Note: AOT is enabled by default. To disable AOT for this recipe, add: | |
| // #:property PublishAot=false |
| @@ -1,5 +1,4 @@ | |||
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |||
| #:property PublishAot=false | |||
|
|
|||
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.
| // Note: AOT (PublishAot) is enabled by default for this recipe. | |
| // To disable AOT, add the following directive above: | |
| // #:property PublishAot=false |
| @@ -1,5 +1,4 @@ | |||
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |||
| #:property PublishAot=false | |||
|
|
|||
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.
| // NOTE: This recipe publishes with Native AOT enabled by default. | |
| // To disable AOT for this recipe (for example, if you hit platform or tooling | |
| // limitations), add the following directive at the top of this file: | |
| // | |
| // #:property PublishAot=false | |
| // | |
| // This overrides the default and publishes a non-AOT binary instead. |
| @@ -1,5 +1,4 @@ | |||
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |||
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |
| #:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj | |
| // Note: AOT (PublishAot) is enabled by default for this recipe. | |
| // To disable AOT for this sample, you can add the directive: | |
| // #:property PublishAot=false |
No description provided.