Use Pydantic for weather parameters in get_weather #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the get_weather tool example in the documentation to use Pydantic models with Field descriptions for parameter validation. The change addresses an issue where LLMs do not properly pass the city parameter when parameter descriptions are not provided, as Field descriptions become part of the JSON schema exposed to the LLM.
Changes:
- Added Pydantic BaseModel import and Field import to the Python example
- Created a
GetWeatherParamsclass with acityfield that includes a description - Updated the
get_weatherfunction signature to acceptGetWeatherParamsinstead ofdict - Changed parameter access from dictionary-style (
params["city"]) to attribute-style (params.city)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactor get_weather function to use Pydantic for parameter validation. LLM does not reliably pass the name of the city if the parameter description is not provided.
friggeri
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor get_weather function to use Pydantic for parameter validation. LLM does not pass the name of the city if the parameter description is not provided.