Skip to content

Conversation

@aaronpowell
Copy link
Contributor

No description provided.

@aaronpowell aaronpowell requested a review from a team as a code owner January 22, 2026 05:30
Copilot AI review requested due to automatic review settings January 22, 2026 05:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds .NET support to the development container by adding the dotnet feature to the devcontainer configuration.

Changes:

  • Added the dotnet feature from the official devcontainers features repository to enable .NET development capabilities

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"ghcr.io/devcontainers-extra/features/uv:1": {},
"ghcr.io/schlich/devcontainer-features/just:0": {}
"ghcr.io/schlich/devcontainer-features/just:0": {},
"ghcr.io/devcontainers/features/dotnet": {}
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dotnet feature specification is missing a version number. All other features in this configuration explicitly specify versions (e.g., ":1", ":0"). For consistency and to ensure predictable behavior, this should include a version specification. Consider using "ghcr.io/devcontainers/features/dotnet:1" to match the pattern used by other features from the same source.

Suggested change
"ghcr.io/devcontainers/features/dotnet": {}
"ghcr.io/devcontainers/features/dotnet:1": {}

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronpowell Can you comment on this? Is the :1 here the version of https://github.com/devcontainers/features/pkgs/container/features%2Fdotnet or something else?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveSandersonMS I believe this should be

  "ghcr.io/devcontainers/features/dotnet:2.4.2": {}

per the link you shared

Copy link
Collaborator

@friggeri friggeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pin the version of the feature, as Copilot is recommending?

@aaronpowell
Copy link
Contributor Author

Can you pin the version of the feature, as Copilot is recommending?

Done. Used a major release rather than a very specific one, to be consistent with other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants