-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(web): allow session resume without new message (#4100) #4185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Akshat8510
wants to merge
19
commits into
google:main
Choose a base branch
from
Akshat8510:fix/fastapi-resume-4100
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
−8
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fe24e72
fix(web): allow session resume without new message (#4100)
Akshat8510 1f4f0aa
fix(web): adds a unit test verifying that the /run endpoint accepts r…
Akshat8510 929fe2e
fix: allow agent session resumption without new message
Akshat8510 1afb89a
Style: cleanup unit test by removing unnecessary logging and blank lines
Akshat8510 d10c1d3
fix: add observability logging for no-op resume and cleanup tests
Akshat8510 00b0f20
fix: align dummy runner logic with real runner and update docstring
Akshat8510 2987931
docs: remove misleading comment in unit test per bot feedback
Akshat8510 c2511c5
fix: handle state_delta warning in no-op resume and cleanup dummy runner
Akshat8510 ac9f904
fix: the formatting
Akshat8510 1fdf7ef
fix: finalize session resumption logic and test coverage
Akshat8510 5af99c7
fix: align mock warning with production and update docstring
Akshat8510 e3ed269
test: improve robustness of no-op resume warning assertion
Akshat8510 d8d3401
test: improve robustness of no-op resume warning assertion
Akshat8510 c5ac29a
fix: implement graceful session resumption and separate test concerns
Akshat8510 a397ea3
refactor: use targeted mocks for session resumption tests per bot fee…
Akshat8510 222cd2d
refactor: remove logic duplication in global mock per bot feedback
Akshat8510 1faac6f
refactor: use parameterized tests for session resumption scenarios
Akshat8510 74bb3db
style: use explicit empty loop for async generator mock per bot feedback
Akshat8510 ee6ab89
Merge branch 'main' into fix/fastapi-resume-4100
Akshat8510 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.