Skip to content

Conversation

@jayy-77
Copy link

@jayy-77 jayy-77 commented Jan 23, 2026

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

#4240

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jayy-77, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant feature that enables Server-Sent Events (SSE) streaming for agents when they are converted into A2A Starlette applications. This enhancement provides a mechanism for real-time, incremental delivery of agent responses, improving user experience by allowing data to be pushed from the server to the client as it becomes available. The changes involve adding a new configuration option for streaming and integrating it across various components of the ADK framework to support this functionality.

Highlights

  • SSE Streaming Support: Introduced the StreamingMode enum to enable Server-Sent Events (SSE) for real-time streaming of agent responses, enhancing the responsiveness of agent applications.
  • Configurable Streaming Mode: The to_a2a utility function now accepts an optional streaming_mode parameter, allowing users to explicitly configure the desired streaming behavior, such as StreamingMode.SSE.
  • Internal Integration: The chosen streaming_mode is seamlessly propagated through the A2aAgentExecutorConfig and request_converter components, ensuring that the agent's RunConfig respects the specified streaming preference during execution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the live [Component] This issue is related to live, voice and video chat label Jan 23, 2026
@adk-bot
Copy link
Collaborator

adk-bot commented Jan 23, 2026

Response from ADK Triaging Agent

Hello @jayy-77, thank you for your contribution!

To help us review this PR, could you please fill out the "Testing Plan" section in the PR description? This information is important for the reviewers to understand how you have tested your changes.

You can find more details in our contribution guidelines.

Thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Server-Sent Events (SSE) streaming capabilities by integrating a StreamingMode enum throughout the A2A conversion and execution pipeline. The changes correctly propagate the streaming_mode from the to_a2a function, through the A2aAgentExecutorConfig, and into the RunConfig used by the ADK runner. The implementation ensures that if no specific streaming mode is provided, it defaults to StreamingMode.NONE, maintaining existing behavior. The code is well-structured, and the docstrings and type hints have been updated appropriately to reflect the new parameter, enhancing clarity and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

live [Component] This issue is related to live, voice and video chat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants