-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Feat: sse_streaming #4254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: sse_streaming #4254
Conversation
Summary of ChangesHello @jayy-77, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant feature that enables Server-Sent Events (SSE) streaming for agents when they are converted into A2A Starlette applications. This enhancement provides a mechanism for real-time, incremental delivery of agent responses, improving user experience by allowing data to be pushed from the server to the client as it becomes available. The changes involve adding a new configuration option for streaming and integrating it across various components of the ADK framework to support this functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @jayy-77, thank you for your contribution! To help us review this PR, could you please fill out the "Testing Plan" section in the PR description? This information is important for the reviewers to understand how you have tested your changes. You can find more details in our contribution guidelines. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Server-Sent Events (SSE) streaming capabilities by integrating a StreamingMode enum throughout the A2A conversion and execution pipeline. The changes correctly propagate the streaming_mode from the to_a2a function, through the A2aAgentExecutorConfig, and into the RunConfig used by the ADK runner. The implementation ensures that if no specific streaming mode is provided, it defaults to StreamingMode.NONE, maintaining existing behavior. The code is well-structured, and the docstrings and type hints have been updated appropriately to reflect the new parameter, enhancing clarity and maintainability.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
#4240
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.