OIDC datagatherer #758
Open
OIDC datagatherer #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inteon
force-pushed
the
oidc_datagatherer
branch
3 times, most recently
from
539b172 to
b4e4169
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
oidc_datagatherer
branch
from
b4e4169 to
5fa2201
Compare
SgtCoDFish
requested changes
Jan 23, 2026
Comment on lines
+51
to
+53
| func (g *DataGathererOIDC) Run(ctx context.Context) error { | ||
| return nil | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: probably worth having a comment here explaining why it does nothing!
Contributor
There was a problem hiding this comment.
Am I missing the change here? It still seems like there's no comment?
Contributor
Author
There was a problem hiding this comment.
I added var _ datagatherer.DataGatherer = &DataGathererOIDC{} to make it clear that this struct is implementing an interface.
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
oidc_datagatherer
branch
from
75bf546 to
2a994be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds datagatherer that fetches the
/.well-known/openid-configurationand/openid/v1/jwksendpoints.Adding this gathered data to the disco upload is for a follow-up PR.