-
Notifications
You must be signed in to change notification settings - Fork 24
Add Claude.md #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Claude.md #112
Conversation
|
I've assigned @joostjager as a reviewer! |
joostjager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see claude change behavior with this file present?
|
Apparently this file is loaded into the context at the start of every session. Recommendation is too keep it short and only have it contain non-obvious things. |
Used /init in claude code to make initial structure than added some notes myself.
7ac7495 to
54f6dd2
Compare
|
Simplified claude.md a lot and made a contributing.md that has more details |
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one question though.
| RUSTFLAGS="--cfg genproto" cargo build -p ldk-server-protos | ||
| ``` | ||
|
|
||
| After regenerating, you must manually readd the copyright header to each generated file in `ldk-server-protos/src/` ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a script to do this, or even just do it as part of build.rs? This would help us, but also help Claude not mess something up?
Used
/initin claude code to make initial structure than added some notes myself.