Skip to content

Conversation

@benthecarman
Copy link
Collaborator

Used /init in claude code to make initial structure than added some notes myself.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 22, 2026

I've assigned @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see claude change behavior with this file present?

@joostjager
Copy link
Contributor

Apparently this file is loaded into the context at the start of every session. Recommendation is too keep it short and only have it contain non-obvious things.

Used /init in claude code to make initial structure than added some
notes myself.
@benthecarman
Copy link
Collaborator Author

Simplified claude.md a lot and made a contributing.md that has more details

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question though.

RUSTFLAGS="--cfg genproto" cargo build -p ldk-server-protos
```

After regenerating, you must manually readd the copyright header to each generated file in `ldk-server-protos/src/` (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a script to do this, or even just do it as part of build.rs? This would help us, but also help Claude not mess something up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants