[GIT-40]fix: apply sub-issue display filter when adding work items

[vamsikrishnamathala]

Description

This fix ensures that Sub-work items are not added to the main issue list when the user has disabled the "Show sub Work items" display filter. Previously, work items would still appear in the list regardless of this setting.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

#8505

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Sub-issues now properly respect the sub-work item display filter setting. When the display of sub-work items is disabled in your filter settings, sub-issues will no longer appear in grouped issue lists, providing better control over your workspace organization.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A conditional filter check was added to the issue store's sub-issue addition logic. When adding a new sub-issue, the code now verifies whether sub-work item display is enabled via the sub_issue display filter before updating grouped issue lists.

Changes

Cohort / File(s)	Summary
Sub-issue Display Filtering apps/web/core/store/issue/helpers/base-issues.store.ts	Added conditional gate to skip grouped issue list updates when adding sub-issues if the sub_issue display filter is disabled. Change only affects ADD action; DELETE and REORDER paths remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A filter so fine, a gate at the door,
Sub-issues now hide when we choose to ignore,
Five lines of logic, clean and precise,
Display what we wish—oh, how very nice! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: applying a sub-issue display filter when adding work items, which matches the core functionality change in the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The PR description follows the required template with all major sections completed: a clear description of the bug fix, correct type of change selected, and a reference to the related issue.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[makeplane]

Linked to Plane Work Item(s)

• [GIT-40] [bug]: filter sub-work items

This comment was auto-generated by Plane

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/web/core/store/issue/helpers/base-issues.store.ts (1)

1213-1214: LGTM - Correctly prevents sub-issues from being added when filter is disabled.

The logic correctly skips both the issue ID addition and count accumulation when a sub-issue is being added while the display filter is off. DELETE and REORDER operations remain unaffected, which is the expected behavior.

Minor optional improvement: The variable isSubIssue stores the parent_id string value rather than a boolean. For slightly clearer intent, consider using Boolean(issue?.parent_id) or renaming to parentId:

💡 Optional: Improve variable naming clarity

         if (issueUpdate.action === EIssueGroupedAction.ADD) {
-          const isSubIssue = issue?.parent_id;
-          if (isSubIssue && !isShowWorkItemsEnabled) continue;
+          const hasParent = Boolean(issue?.parent_id);
+          if (hasParent && !isShowWorkItemsEnabled) continue;

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8399f64 and 10cb9b6.

📒 Files selected for processing (1)

• apps/web/core/store/issue/helpers/base-issues.store.ts

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx,mts,cts}

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

**/*.{ts,tsx,mts,cts}: Use const type parameters for more precise literal inference in TypeScript 5.0+
Use the satisfies operator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicit is return types in filter/check functions
Use NoInfer<T> utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing in switch(true) blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacy experimentalDecorators
Use using declarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Use with { type: "json" } for import attributes; avoid deprecated assert syntax (TypeScript 5.3/5.8+)
Use import type explicitly when importing types to ensure they are erased during compilation, respecting verbatimModuleSyntax flag
Use .ts, .mts, .cts extensions in import type statements (TypeScript 5.2+)
Use import type { Type } from "mod" with { "resolution-mode": "import" } for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize new Set methods like union, intersection, etc., when available (TypeScript 5.5+)
Use Object.groupBy / Map.groupBy standard methods for grouping instead of external libraries (TypeScript 5.4+)
Use Promise.withResolvers() for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted, toSpliced, with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields via super in classes (TypeScript 5....

Files:

• apps/web/core/store/issue/helpers/base-issues.store.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Enable TypeScript strict mode and ensure all files are fully typed

Files:

• apps/web/core/store/issue/helpers/base-issues.store.ts

**/*.{js,jsx,ts,tsx,json,css}

📄 CodeRabbit inference engine (AGENTS.md)

Use Prettier with Tailwind plugin for code formatting, run pnpm fix:format

Files:

• apps/web/core/store/issue/helpers/base-issues.store.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately

Files:

• apps/web/core/store/issue/helpers/base-issues.store.ts

🧠 Learnings (1)

📚 Learning: 2025-06-16T07:23:39.497Z

Learnt from: vamsikrishnamathala
Repo: makeplane/plane PR: 7214
File: web/core/store/issue/helpers/base-issues.store.ts:117-117
Timestamp: 2025-06-16T07:23:39.497Z
Learning: In the updateIssueDates method of BaseIssuesStore (web/core/store/issue/helpers/base-issues.store.ts), the projectId parameter is intentionally made optional to support override implementations in subclasses. The base implementation requires projectId and includes an early return check, but making it optional allows derived classes to override the method with different parameter requirements.

Applied to files:

• apps/web/core/store/issue/helpers/base-issues.store.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build packages
• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

apps/web/core/store/issue/helpers/base-issues.store.ts (1)

1201-1203: LGTM - Filter retrieval is correctly implemented.

The optional chaining and nullish coalescing handle undefined filter states safely. The default of false means sub-issues will be hidden when the filter isn't explicitly set, which aligns with the bug fix intent.