Enhanced Subscription & Billing demo data for Power BI reporting #6143
Conversation
New updates to Sub & Billing Demo Data app: - Updated last used no series. - Added subscriptions - Added customer and vendor subscription contracts - Created analysis entries for PowerBI reporting. http://bcdev2.fenwicksoftware.com.au:10470/BC/?company=DemoSB3 Related work items: #29613
github-actions
bot
added
AL: Apps (W1)
| end; | ||
| end; | ||
|
|
||
| local procedure CreateContractAnalysisEntry(ServiceCommitment: Record "Subscription Line"; AnalysisDate: Date) |
There was a problem hiding this comment.
| local procedure CreateContractAnalysisEntry(ServiceCommitment: Record "Subscription Line"; AnalysisDate: Date) | |
| local procedure CreateContractAnalysisEntry(SubscriptionLine: Record "Subscription Line"; AnalysisDate: Date) |
I am not familiar with this record so maybe your name makes more sense, but generally we name the record variables exactly like their source table.
There was a problem hiding this comment.
@attilatoury I'm not sure why they aren't same here. I followed the same naming convention that's used within this Sub & Billing Demo Data app. And yes, normally it would be the same name as the record in AL.
There was a problem hiding this comment.
I updated this changed anyway
|
|
||
| ServiceObject.Validate("End-User Customer No.", CustomerNo); | ||
| ServiceObject.Validate("Provision Start Date", ProvisionStartDate); | ||
| if ProvisionEndDate <> 0D then |
There was a problem hiding this comment.
Should we check that StartDate < EndDate? Unless it is already done in the table field's OnValidate trigger.
There was a problem hiding this comment.
Thank you, there is no onvalidate code. I've added this check.
| VendorContract.CreateVendorContractLineFromServiceCommitment(ServiceCommitment); | ||
| end; | ||
|
|
||
| procedure AddVendorContractLine(ContractNo: Code[20]; ObjectNo: Code[20]) |
There was a problem hiding this comment.
Call this procedure at the end of the procedure above (InsertVendorContractLine) if it is intended to do the same thing
There was a problem hiding this comment.
I've updated this change
3 participants
Summary
Subscription & Billing Demo Data
Work Item(s)
Fixes #6142
Fixes AB#614285