Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 23, 2026

Avatar URLs on GitHub Enterprise Server are inaccessible to the extension, causing failed fetches and missing icons in PR/Issue tree views. Enterprise detection was working in editor webviews but not in tree nodes.

Changes

  • Tree view nodes: Add isEnterprise check before avatar fetch attempts

    • pullRequestNode.ts: Extract _getAuthorIcon() helper to eliminate duplication
    • issuesView.ts: Check enterprise before rendering issue avatars
    • commitNode.ts: Check enterprise before rendering commit author avatars (fix iconPath type)
    • repositoryChangesNode.ts: Check enterprise before rendering PR author avatars
  • Behavior: Enterprise remotes skip fetch and use github ThemeIcon immediately; non-enterprise unchanged

// Before: Always attempted fetch, failed for enterprise
this.iconPath = (await DataUri.avatarCirclesAsImageDataUris(context, [author], 16, 16))[0];

// After: Skip fetch for enterprise
if (pullRequest.githubRepository.remote.isEnterprise) {
    this.iconPath = new vscode.ThemeIcon('github');
} else {
    this.iconPath = (await DataUri.avatarCirclesAsImageDataUris(context, [author], 16, 16))[0];
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • update.code.visualstudio.com
    • Triggering command: /opt/hostedtoolcache/node/20.20.0/x64/bin/node node ./out/src/test/runTests.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Avatar does not show in PR details page</issue_title>
<issue_description>

  • Extension version: 0.122.0
  • VSCode Version: 1.106.0
  • OS: Windows 11 25H2
  • Repository Clone Configuration (single repository/fork of an upstream repository): single repo
  • GitHub Product (GitHub.com/GitHub Enterprise version): GHES 3.14.8

Steps to Reproduce:

  1. Create a PR
  2. Open PR details page in editor
  3. Avatar is missing/replaced by placeholder
Image Image Image

</issue_description>

<agent_instructions>Fix the icon not showing in the PRs and Issues views for enterprise.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@alexr00 We can't load enterprise avatars. I will switch us to use placeholders. @TylerLeonhardt Image

looks like the tree views need the treatment still. The PR & Issue editors look good though (using the default GitHub icon)

That said, should they use the account codicon? I don't feel too strongly about it either way.</comment_new>


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits January 23, 2026 17:46
- Add enterprise detection in PR tree views
- Use github ThemeIcon placeholder for enterprise instead of fetching avatars
- Update pullRequestNode, issuesView, commitNode, and repositoryChangesNode

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
…uestNode

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix avatar display issue on PR details page Fix avatar display in tree views for GitHub Enterprise Jan 23, 2026
Copilot AI requested a review from alexr00 January 23, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avatar does not show in PR details page

2 participants