fix(account): use classification state from account #12313
Draft
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Member
yes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State 1
AccountForm used in setup view. The value for the classification checkbox should follow the default (admin -> groupware -> classification). ✅
State 2
Configuration for classification in account settings. Is using the account value. ✅
State 3
AccountForm used in accounts settings view. The checkbox is using the global default like in the setup view. ❌
To clarify
It appears weird, to have the classification two times in the account settings. With this change applied, the one in the account form at least also shows the right state.
Should we probably remove/hide when not in setup?