Fix incorrect user count #57736
Open
Fix incorrect user count #57736
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Mueller <muellersebastian@mail.com>
Signed-off-by: Sebastian Mueller <muellersebastian@mail.com>
Sebastianmueller22
requested review from
ArtificialOwl,
CarlSchwan,
icewind1991 and
salmart-dev
and removed request for
a team
CarlSchwan
reviewed
Jan 23, 2026
|
|
||
|
|
||
| // display user count with a plus appended, if limit is exceeded | ||
| $userCount = ($userCount < self::COUNT_LIMIT_FOR_SUBADMINS) ? $userCount : self::COUNT_LIMIT_FOR_SUBADMINS . '+'; |
Member
There was a problem hiding this comment.
This will change the return type in the frontend, not sure what are the consequence of that
Author
There was a problem hiding this comment.
It didn't produce any issue in my test. I looked for usages and it seems to be handled in a type agnostic way. I did it in oder to not have the limit hard coded in the frontend as well.
I could alternatively send the limit with the response and make the check in the frontend. Should I do that instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a simple check if the limit is exceeded it adds a plus. Tested with a system with that many users in a subgroup and it showed up correctly.
Resolves #54878
Checklist
3. to review, feature component)stable32)