[CHORE] Force conversion of classic histograms into NHCB #45611
+112
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Contributor
|
I think this makes a ton of sense |
Contributor
|
BTW: Future scrape protocols will only support this case better (e.g. OpenMetrics 2.0) |
bwplotka
approved these changes
Jan 23, 2026
Contributor
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Would be curious to grab some benchmarks to see if it's improving the efficiency here. I'd expect some benefits.
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Member
Author
|
I've got some weird test failures with this: start time and staleness markers disappearing from the converted NHCB. Not sure yet if this is expected, a bug in prometheus or if more code needs to be refactored here. I couldn't find time to investigate yet though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This idea came up after talking with @bwplotka about the appenderv2 adoption. Is there a reason not to force ScrapeManager to convert classic histograms into NHCB? If we assume all histograms are ingested that way, we could eventually get rid of state handling for classic histograms.
I'm not adding a changelog entry because, theoretically, it has no impact on the end user.
Would love to get your opinions here @dashpole @krajorama