Fix GH-21023: CURLOPT_XFERINFOFUNCTION with invalid callback crash. #21025
Conversation
we check the FCC is properly initialised beforehand in its handler.
| $ch = curl_init($url); | ||
| curl_setopt($ch, CURLOPT_NOPROGRESS, 0); | ||
| curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1); | ||
| curl_setopt($ch, CURLOPT_XFERINFOFUNCTION, $callback); |
There was a problem hiding this comment.
It seems the CURLOPT_PROGRESSFUNCTION and CURLOPT_XFERINFOFUNCTION are aliases... should we deprecate one, or explicitly mark one constant as the alias of the other?
There was a problem hiding this comment.
PROGRESS is the one to be deprecated, we should at some point before next major release IMHO
| return rval; | ||
| } |
There was a problem hiding this comment.
I don't really understand how this can happen. It shouldn't be possible for this state to arise as this condition should be caught by the HANDLE_CURL_OPTION_CALLABLE, no? Or am I missing something here?
There was a problem hiding this comment.
no it is not, when I debugged php_curl_set_callable_handler earlier, the fcc was not initialised despite being succesful.
| $ch = curl_init($url); | ||
| curl_setopt($ch, CURLOPT_NOPROGRESS, 0); | ||
| curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1); | ||
| curl_setopt($ch, CURLOPT_XFERINFOFUNCTION, $callback); |
There was a problem hiding this comment.
| curl_setopt($ch, CURLOPT_XFERINFOFUNCTION, $callback); | |
| curl_setopt($ch, CURLOPT_XFERINFOFUNCTION, null); |
There was a problem hiding this comment.
I am afraid it is not the same as here, it s an undefined var.
| curl_exec($ch); | ||
| $ch = curl_init($url); | ||
| curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1); | ||
| curl_setopt($ch, CURLOPT_PROGRESSFUNCTION, $callback); |
There was a problem hiding this comment.
| curl_setopt($ch, CURLOPT_PROGRESSFUNCTION, $callback); | |
| curl_setopt($ch, CURLOPT_PROGRESSFUNCTION, null); |
2 participants
we check the FCC is properly initialised beforehand.