PostgresNode::start and start2 are updated #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgresNode::_start it an internal method without default paramseters. It is called by start and start2 methods. Also: - typing - argument "params" can be None now
They use the new utility PostgresNodeTestUtils.wait_for_running_state.
dmitry-lipetsk
force-pushed
the
D20260123_001--node-start-is-updated
branch
from
bd7c351 to
eed89f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
paramscan beNoneorliststart2documentation is correctedstartandstart2are using new internal method_startthat does not have default parameters