PEP 807: make discovery procedure reversible #4791
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my last intended change to PEP 807 before submitting to another round of review.
What I've done here is make the discovery flow (which was already defined in the PEP) reversible: the previous flow used a strong trapdoor function (SHA-256) to compute the "discovery key," which effectively meant that indices would need to precompute every valid discovery key. This quickly becomes infeasible (or at least very annoying) for index topologies with ~thousands of distinct upload endpoints, particularly if those endpoints can vary by case, escaping, etc.
The alternative is much simpler: instead of using a trapdoor function, we compute the discovery key as a query-safe URL encoding. This is completely reversible, less opaque, and is equally built into Python (with
quote_plus).📚 Documentation preview 📚: https://pep-previews--4791.org.readthedocs.build/