Update DigiCert to match new schema #15
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DigiCert plugin to conform to a new schema version 2.0 by restructuring the configuration properties in the metadata and datastream files.
Changes:
- Restructured base plugin configuration to use nested
baseobject - Renamed datastream configuration properties from
dataSourceConfigtoconfiganddataSourceNametobaseDataSourceName
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/DigiCert/v1/metadata.json | Restructured base plugin configuration into nested base object with plugin, majorVersion, and config properties |
| plugins/DigiCert/v1/data_streams/certificateOrders.json | Renamed dataSourceConfig to config and dataSourceName to baseDataSourceName |
| plugins/DigiCert/v1/data_streams/accountUsers.json | Renamed dataSourceConfig to config and dataSourceName to baseDataSourceName |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Summary
Renaming some folders and properties to conform to the new schema
🔗 Related issue(s)
🧩 Plugin details
Does this PR introduce any breaking changes?
If yes, describe:
📚 Documentation
✅ Checklist