fix: no delay between batch jobs #739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayubun
force-pushed
the
search-delay-for-jobs
branch
from
735dd6e to
1aba4cc
Compare
ayubun
changed the title
searchDelay between batch jobssearchDelay between batch jobs
ayubun
force-pushed
the
search-delay-for-jobs
branch
2 times, most recently
from
8ebd94c to
82b61fd
Compare
ayubun
changed the title
searchDelay between batch jobs
ayubun
force-pushed
the
search-delay-for-jobs
branch
from
82b61fd to
12d0182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running batch jobs, the first api search for each job does not have any search delay. this is not a problem when running a single job, but when there are subsequent jobs, it will spam the api:
i believe this is a remnant of the code pre-batching, where such a delay is unneeded. i've added a simple check to apply a
jobDelaybefore running if the current job is not the first one.i'm not keen on making frontend changes so this option is currently backend only; i'd rather it be supported without UX to change it than to spam jobs >.<
note: my personal contributions to and usage of this project do not represent discord. opinions are my own