Skip to content

Conversation

@xihale
Copy link
Member

@xihale xihale commented Jan 24, 2026

No description provided.

@xihale xihale marked this pull request as ready for review January 24, 2026 03:09
@gemini-code-assist
Copy link

Summary of Changes

Hello @xihale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request shifts the project's dependency management for KaTeX and Mermaid from external CDNs to local self-hosting. This change enhances control over asset delivery, potentially improving loading reliability and reducing external network dependencies for rendering mathematical equations and diagrams.

Highlights

  • Self-hosted KaTeX Assets: KaTeX CSS and JavaScript files, including the auto-render plugin, are now hosted directly within the project's assets, moving away from CDN reliance.
  • Self-hosted Mermaid Assets: The Mermaid JavaScript library is also now self-hosted, ensuring local availability for diagram rendering.
  • Updated Asset References: The project's templates (layouts/post.shtml) and content files (content/post/2025-07-19-zine-migration.smd) have been updated to reference these newly self-hosted assets.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request's goal to self-host KaTeX and Mermaid assets is a great initiative for improving performance and reliability. The implementation correctly updates the asset paths in layouts/post.shtml and the related documentation. However, the PR is currently broken because the main JavaScript files for both KaTeX (katex.min.js) and Mermaid (mermaid.min.js) are referenced but missing from the repository. Additionally, a large number of KaTeX files that don't seem to be used have been added, which could unnecessarily increase the repository's size. I've left a few comments with suggestions to fix these issues.

@xihale xihale merged commit eb75726 into zigcc:main Jan 24, 2026
3 checks passed
@xihale xihale deleted the fix-cdn branch January 24, 2026 03:21
xihale added a commit that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant